Make rule-preprocessor process a single directory at a time - #372
Merged
nunoplopes merged 2 commits intoSep 18, 2026
Merged
Conversation
joaotgouveia
force-pushed
the
single-dir-preprocessor
branch
from
September 16, 2026 02:29
26f238b to
f94decf
Compare
nunoplopes
reviewed
Sep 17, 2026
| OUTPUT_STRIP_TRAILING_WHITESPACE | ||
| ) | ||
|
|
||
| add_custom_command( |
Contributor
There was a problem hiding this comment.
this should be split in two rules, each output its own binary. Then there's no need for this PREPROCESSOR_STAMP
Contributor
Author
There was a problem hiding this comment.
I'll split building the rules crate and the rule-preprocessor, keeping both commands together is not necessary since they are independent. However, preprocessing rust rules depends on both commands, one ensures the binary itself is build, and the other ensures that the rules crate dependencies are built.
Since preprocessing rust rules depends on the built dependencies, and not on the RUSTLS_HEADER the rules crate command outputs, won't it be clearer to keep the PREPROCESSOR_STAMP as an output of this command as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
rule-preprocessorto process a single directory per invocation, making it possible to parallelize. This matches what is already the case forcpp-rule-preprocessor. Additionally, this dropsmodules.rsfrom source control.